Conversation
Tested manually - value is in miliseconds, not seconds. But I'm not sure how about https://github.com/apache/cloudstack/blob/1d05fead49f5c856257a741b07122f5633d2e359/engine/schema/src/main/resources/META-INF/db/schema-41000to41100.sql#L258 - since it does insert of this setting with also wrong wording
yadvr
approved these changes
Jun 25, 2019
Member
|
Since this is strictly a doc string change, LGTM based on travis job1 https://travis-ci.org/apache/cloudstack/jobs/549120173, packging+smoketests are not necessary. |
anuragaw
approved these changes
Jun 25, 2019
Contributor
anuragaw
left a comment
anuragaw
left a comment
There was a problem hiding this comment.
Verified usage indeed aims for millisseconds in StatsCollector
if (volumeStatsInterval > 0) {
_executor.scheduleAtFixedRate(new VolumeStatsTask(), 15000L, volumeStatsInterval, TimeUnit.MILLISECONDS);
}
Member
|
Merging based on reviews and 1st job of travis: https://travis-ci.org/apache/cloudstack/jobs/549120173 Note: this fixes only the description on fresh installation. |
Contributor
Author
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested manually - value is in miliseconds, not seconds.
But I'm not sure how about
cloudstack/engine/schema/src/main/resources/META-INF/db/schema-41000to41100.sql
Line 258 in 1d05fea
Description
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?